-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/codecov experiment #76
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 0.00% 86.73% +86.73%
==========================================
Files 16 16
Lines 1523 1523
==========================================
+ Hits 0 1321 +1321
+ Misses 1523 202 -1321
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@giovp, it takes a little bit for the coverage action to run, and it's not added to the checks until after it runs. Maybe we should make it a required check? |
- name: Install dependencies | ||
run: | | ||
pip install ".[dev,test]" | ||
pip install -e ".[dev,test]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think this made it work? or what was it otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it wasn't collecting the coverage otherwise. I can locally reproduce that installing without -e
prevents collection of the coverage.
I vaguely remember this being an issue before. I think it came up for anndata – though it's not using -e
now and I can't tell what's different 😅. There's also some reason we make the cookiecutter do an editable install too.
I think it had something to do with the install being a wheel, and being able to trace the code being tested to the wheel?
we could make it a required check |
I'll merge this then open an issue for getting coverage to run without doing an editable install |
Experimenting to get #71 working