Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(1-1-restore): adds node-mapping validation to the sctool #4248

Draft
wants to merge 1 commit into
base: 1-1-restore-feature-branch
Choose a base branch
from
Draft

feat(1-1-restore): adds node-mapping validation to the sctool #4248

wants to merge 1 commit into from

Conversation

VAveryanov8
Copy link
Collaborator

This adds --node-mapping validation to the sctool. Mainly to cover cases such as dc count mismatch and rack count mismatch.

Follow up: #4230

Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@VAveryanov8
feat(1-1-restore): adds node-mapping validation to the sctool
19e0b62 
This adds `--node-mapping` to the sctool. Mainly to cover cases such as
dc count mismatch and rack count mismatch.

Follow up: #4230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karol-kokoszka karol-kokoszka Awaiting requested review from karol-kokoszka karol-kokoszka will be requested when the pull request is marked ready for review karol-kokoszka is a code owner

@Michal-Leszczynski Michal-Leszczynski Awaiting requested review from Michal-Leszczynski Michal-Leszczynski will be requested when the pull request is marked ready for review Michal-Leszczynski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VAveryanov8