treewide: get rid of (most) uses of QueryResult::rows
#955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wprzytula
force-pushed
the
dont-use-raw-rows
branch
2 times, most recently
from
a34c5a1 to
9ee0ee1
Compare
Lorak-mmk
requested changes
Mar 14, 2024
wprzytula
force-pushed
the
dont-use-raw-rows
branch
from
9ee0ee1 to
9316106
Compare
This commit serves two purposes: - Modernizes the existing examples and internal uses of QueryResult in the driver. We have had helpers such as rows_typed etc. for a long time and they are supposed to offer superior experience, although many of our tests still use QueryResult::rows directly. - Prepares for the iterator-based deserialization refactor. The representation of QueryResult will change and the rows field will not be available anymore - instead, the helper methods very similar to the current ones will be mandatory. Co-authored-by: Wojciech Przytuła <[email protected]>
wprzytula
force-pushed
the
dont-use-raw-rows
branch
from
9316106 to
9a7fceb
Compare
Lorak-mmk
approved these changes
Mar 14, 2024
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #462.
This PR serves two purposes:
QueryResultin the driver. We have had helpers such as rows_typed etc. for a long time and they are supposed to offer superior experience, although many of our tests still useQueryResult::rowsdirectly.QueryResultwill change and the rows field will not be available anymore - instead, the helper methods very similar to the current ones will be mandatory.Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce../docs/source/.[ ] I added appropriateFixes:annotations to PR description.