http: Unwrap nested exceptions to handle retryable transport errors #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the HTTP client's exception handling by unwrapping nested exceptions. This allows the client to detect retryable transport errors even when they're encapsulated within multiple layers of exceptions. By identifying these underlying transport errors, the client can implement appropriate retry logic, improving reliability during transient network issues. Also add TLS error which is clearly retryable.
kreuzerkrieg
force-pushed
the
nested-exceptions
branch
from
c347a83 to
406f309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the HTTP client's exception handling by unwrapping nested exceptions. This allows the client to detect retryable transport errors even when they're encapsulated within multiple layers of exceptions. By identifying these underlying transport errors, the client can implement appropriate retry logic, improving reliability during transient network issues.
Also add GNUTLS_E_PREMATURE_TERMINATION error to the list of retryable error since technically it is a transport issue