Fix keyword arguments and stream specs

[ghost]

Ruby 3.0 handles keyword arguments differently: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

This attempts to fix that issue. Note there are still two warnings that I'm not sure how to fix in redis_multiplexer.rb method_missing.

[sds]

Thank you!

[pyromaniac]

This patch seem to be causing issues in ruby 2.6 I believe you had to add ruby2_keywords gem to the list of dependencies as well, otherwise it doesn't get loaded before mock_redis

[ghost]

@pyromaniac I did update the Gemfile: https://github.com/sds/mock_redis/blob/master/Gemfile#L12

Hmm but not the gemspec: https://github.com/sds/mock_redis/blob/master/mock_redis.gemspec.#199. I think we need this in the gemspec:

s.add_runtime_dependency 'ruby2_keywords'

[pyromaniac]

Yeah, that's what I meant, sorry :)

[ghost]

@sds can you add s.add_runtime_dependency 'ruby2_keywords' to the gemspec?

[pyromaniac]

Oh well, thanks for releasing it with the runtime dep but apparently this is not enough, it still fails. I believe this is because you also need to require 'ruby2_keywords' in the code where it is used. Right now it is required in spec_helper, that's why specs are passing and the actually code doesn't work.

[jdelStrother]

@jasonatball This doesn't cause spec failures for you? Inserting the extra xadd call causes the subsequent xadd to return .........-1 rather than .........-0 for me.

[ghost]

I was maybe lucky that my machine is slow? I can see how that could happen. I'm not sure why that line got there actually. I recently did another PR and ran all the tests successfully. Probably should either delete that line or change to expect(id).