Return targets with spectra by observatory #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imedan Is this ready to be reviewed? If so, can you mark it as ready. |
havok2063
reviewed
Mar 1, 2024
python/valis/routes/query.py
Outdated
Comment on lines
156
to
160
| Query(enum=['APO', 'LCO'], | ||
| description='Observatory to get targets from. Either "APO" or "LCO"', | ||
| example='APO')] = 'APO', | ||
| obsWave: Annotated[str, | ||
| Query(enum=['boss', 'apogee', 'all'], |
There was a problem hiding this comment.
Can you specify default values for obs and obsWave?
There was a problem hiding this comment.
Are default values not set with how it is already written? I assumed having the Query(...) = ... set the default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the feature to return the list of targets with spectra at some observatory. Currently the query works by specifying a data release, an observatory and an instrument.
For just searching on BOSS or APOGEE spectra, the queries seem optimized enough I think (~4.5 sec for BOSS and ~2 sec for APOGEE at APO). Doing the union of both instruments takes much longer (~45 sec). The bottleneck here seems to be sequential scanning from looking at the query plan. I tried to turn this off and test it again, but the query plan says it still uses sequential scanning even after doing this. So, I am unsure what do do about this bit of the feature.