Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding get_target_list_by_mapper endpoint #14

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

mtaghiza
Copy link
Contributor

@mtaghiza mtaghiza commented Feb 15, 2024

(using enum for mapper names)

@mtaghiza mtaghiza requested a review from havok2063 as a code owner February 15, 2024 19:54
Copy link
Contributor

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this endpoint can be simplified a bit first.

# Conflicts:
#	python/valis/db/models.py
#	python/valis/db/queries.py
#	python/valis/routes/query.py
Copy link
Contributor

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small tweak here.

@havok2063 havok2063 merged commit 9466a4f into main Mar 14, 2024
2 checks passed
@havok2063 havok2063 deleted the get_target_list_by_mapper branch June 7, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants