Fix tty truncation #399
Closed
Fix tty truncation #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out the window-seperator crashing was a TTY only issue. This patch disables the fix when running on a graphical display.
seagle0128
reviewed
Dec 29, 2020
| @@ -926,6 +926,13 @@ then this function does nothing." | |||
| (add-hook 'after-setting-font-hook #'doom-modeline-refresh-font-width-cache) | |||
| (add-hook 'server-after-make-frame-hook #'doom-modeline-refresh-font-width-cache) | |||
|
|
|||
| (add-hook 'window-configuration-change-hook | |||
There was a problem hiding this comment.
I looks like more than a workaround. The hooks will bring negative performance impacts.
There was a problem hiding this comment.
That was why I didn't send an initial PR. I'm fine with waiting until the issue is fixed in upstream emacs if you'd prefer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #397
Please double check on both GUI and TTY before merge. It works for me but you can never be too sure 😄.