Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor kubeadm/v1beta2 rather than directly import this golang file #1743

Closed
allencloud opened this issue Sep 28, 2022 · 2 comments · Fixed by #1758
Closed

vendor kubeadm/v1beta2 rather than directly import this golang file #1743

allencloud opened this issue Sep 28, 2022 · 2 comments · Fixed by #1758
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@allencloud
Copy link
Member

allencloud commented Sep 28, 2022 •
edited
Loading

Issue Description

We found that file https://github.com/sealerio/sealer/blob/main/pkg/runtime/kubernetes/kubeadm/v1beta2/types.go is in sealer's repo code. Actually we should use vendor to import this file of code.

Describe what feature you want

vendor kubeadm/v1beta2 package as we could.

I tried this, while unfortunately I failed. 😨

Additional context

Add any other context or screenshots about the feature request here.
@allencloud allencloud added the kind/feature Category issues or PRs related to feature request label Sep 28, 2022
@allencloud allencloud changed the title vendor vendor kubeadm/v1beta2 rather than directly import this golang file Sep 28, 2022
@allencloud allencloud added good first issue Good for newcomers help wanted Extra attention is needed and removed kind/feature Category issues or PRs related to feature request labels Sep 28, 2022
@zhy76
Copy link
Member

zhy76 commented Sep 28, 2022

Maybe I can try to solve this issue.

@allencloud
Copy link
Member Author

Maybe I can try to solve this issue.

So great. Thanks for your work in advance. @zhy76

@zhy76 zhy76 mentioned this issue Sep 29, 2022
Closed
@jsparter jsparter mentioned this issue Sep 30, 2022
Closed
This was referenced Sep 30, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
2 participants
@allencloud @zhy76