Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor kubeadm/v1beta2 rather than directly import this golang file #1758

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

zhy76
Copy link
Member

@zhy76 zhy76 commented Sep 30, 2022

Signed-off-by: zhy76 [email protected]

Describe what this PR does / why we need it

vendor kubeadm/v1beta2 rather than directly import this golang file

Does this pull request fix one issue?

Fixes #1743

Describe how you did it

I deleted the kubeadm/v1beta2 and vendor kubeadm/v1beta2 rather than directly import this golang file by modifing the go.mod,then I modified the other affected files.I want to only vendor the v1beta2 But it can't work.While vendoring,the whole k8s.io/kubernetes package should vendor too.

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Base: 18.37% // Head: 18.37% // No change to project coverage 👍

Coverage data is based on head (9473531) compared to base (05d696e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1758   +/-   ##
=======================================
  Coverage   18.37%   18.37%           
=======================================
  Files          66       66           
  Lines        5372     5372           
=======================================
  Hits          987      987           
  Misses       4258     4258           
  Partials      127      127           
Impacted Files Coverage Δ
pkg/clusterfile/decoder.go 44.44% <ø> (ø)
pkg/runtime/kubernetes/kubeadm/kubeadm_config.go 53.22% <ø> (ø)
utils/decode.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@justadogistaken
Copy link
Member

I notice that "github.com/sealerio/sealer/pkg/runtime/kubernetes/kubeadm/v1beta2" is not deleted. But I guess we could delete it now, because I have the v1beta2 imported.
Is there any problem to delete the v1beta2 in sealer source code?

@zhy76
Copy link
Member Author

zhy76 commented Oct 1, 2022

I notice that "github.com/sealerio/sealer/pkg/runtime/kubernetes/kubeadm/v1beta2" is not deleted. But I guess we could delete it now, because I have the v1beta2 imported. Is there any problem to delete the v1beta2 in sealer source code?

The “github.com/sealerio/sealer/pkg/runtime/kubernetes/kubeadm/v1beta2” is used by "pkg/clusterfile/decoder.go","pkg/runtime/kubernetes/kubeadm/kubeadm_config.go","pkg/runtime/kubernetes/runtime.go" and "utils/decode.go",and I already changed these files.And I have deleted "github.com/sealerio/sealer/pkg/runtime/kubernetes/kubeadm/v1beta2",it is no problem to delete the v1beta2 in sealer source code.

Copy link
Member

@justadogistaken justadogistaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justadogistaken justadogistaken merged commit 7b1bb6b into sealerio:main Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vendor kubeadm/v1beta2 rather than directly import this golang file
3 participants