optimize: parse the custom resource definitions method refactoring #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakaZhou719
reviewed
May 17, 2022
| Config = "Config" | ||
| Plugin = "Plugin" | ||
| Cluster = "Cluster" | ||
| InitConfiguration = "InitConfiguration" |
There was a problem hiding this comment.
Should we set those special variable with its decode func together ?
utils/yaml/decode.go
Outdated
| "k8s.io/apimachinery/pkg/util/yaml" | ||
| ) | ||
|
|
||
| var decodeCRDFuncMap = map[string]func(reader io.Reader) (interface{}, error){ |
There was a problem hiding this comment.
those logic to do decode file not match with the pkg name yaml means, i think we can move it to decode pkg or another.
|
/test apply |
bxy4543
force-pushed
the
optimize_decode_crd
branch
from
33f420e to
08f31fb
Compare
|
/test apply |
bxy4543
force-pushed
the
optimize_decode_crd
branch
from
08f31fb to
58501fa
Compare
Signed-off-by: wb-hjh933779 <[email protected]>
Signed-off-by: wb-hjh933779 <[email protected]>
Signed-off-by: wb-hjh933779 <[email protected]>
Signed-off-by: wb-hjh933779 <[email protected]>
…d after the paragraph Signed-off-by: wb-hjh933779 <[email protected]>
bxy4543
force-pushed
the
optimize_decode_crd
branch
from
6b8b0fe to
b285fe9
Compare
kakaZhou719
approved these changes
May 20, 2022
bxy4543
force-pushed
the
optimize_decode_crd
branch
from
ca8136d to
3d029e5
Compare
bxy4543
added a commit
to bxy4543/sealer
that referenced
this pull request
Jun 27, 2022
…ealerio#1409) * Parse the Custom Resource Definitions method refactoring Signed-off-by: wb-hjh933779 <[email protected]> * move decode.go file to util pkg Signed-off-by: wb-hjh933779 <[email protected]> * add decode v1 cluster function test . Signed-off-by: wb-hjh933779 <[email protected]> * fix originally phase plugin execution Signed-off-by: wb-hjh933779 <[email protected]> * optimize the writing of the label plugin: ignore the spaces before and after the paragraph Signed-off-by: wb-hjh933779 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve custom resource definition method is too bloated, optimize the structure, support different versions of the resolution of different structures.
kubeadm version v1beta3 structure support later.
Signed-off-by: wb-hjh933779 [email protected]