Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: make sh and /bin/bash compatible on more OS(Ubuntu) #1508

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

allencloud
Copy link
Member

Signed-off-by: Allen Sun [email protected]

Describe what this PR does / why we need it

sh init-registry.sh brings incompatibility on Ubuntu 20.04 LTS. We see that in init-registry.sh there is a shenbang #!/bin/bash. And when using sh to execute file, there will be some places displaying:

+ check_registry
+ n=1
init-registry.sh: 44: cannot open =: No such file
+ n 3
init-registry.sh: 44: n: not found

We update that with ./init-registry, and it would be the default shenbang #!/bin/bash to execute the shell file.

Does this pull request fix one issue?

fixes #1507

Describe how you did it

none

Describe how to verify it

none

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #1508 (1b3de75) into main (bdedd8f) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1508   +/-   ##
=======================================
  Coverage   10.59%   10.59%           
=======================================
  Files          84       84           
  Lines        7629     7629           
=======================================
  Hits          808      808           
  Misses       6719     6719           
  Partials      102      102           
Impacted Files Coverage Δ
pkg/runtime/registry.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdedd8f...1b3de75. Read the comment docs.

@bxy4543 bxy4543 merged commit 2e5c537 into sealerio:main Jun 14, 2022
@allencloud allencloud deleted the compatible-sh branch June 14, 2022 06:26
@allencloud allencloud mentioned this pull request Jun 14, 2022
bxy4543 pushed a commit to bxy4543/sealer that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The func check_registry in init-registry.sh script reports error
4 participants