FIX: skip render the subcharts for sealer build.

[tgfree7]

Signed-off-by: tgfree [email protected]

Describe what this PR does / why we need it

Skip render the subcharts.

Does this pull request fix one issue?

Try to fix #1689

[justadogistaken]

@tgfree7 @kakaZhou719 The render for subcharts should be skipped? I think I need more information.

[tgfree7]

@tgfree7 @kakaZhou719 The render for subcharts should be skipped? I think I need more information.

Render subcharts may list unwanted images, like this:
values.yaml for chart apps-all-in-one

app1:
    Registry: release.com
    image: app1:v1_2022

and values.yaml for subcharts app1 in the apps-all-in-one

Registry: test.com
image: app1:v1_2022

In the case, render the subchart app1 will list the unwanted images. test.com/app1:v1_2022

And render subcharts may cause the tpl error, if app1 call the tpl of _helper.tpl in the apps-all-in-one

[justadogistaken]

@tgfree7 If i'm not mistaken, subcharts has their own values? And of course the parent values could be passed to the subcharts. But what will happen if the user need the "test/com/app1:v1_2022"

[tgfree7]

@tgfree7 If i'm not mistaken, subcharts has their own values? And of course the parent values could be passed to the subcharts. But what will happen if the user need the "test/com/app1:v1_2022"

Yes, subcharts has their own values.yaml.
But when we release the chart apps-all-in-one and set the subchart app1( Registry, images,etc.) by the parent chart values.yaml. this means we just need the image release.com/app1:v1_2022 in this helm chart.
For the chart apps-all-in-one, we release the apps(app1,app2,etc) in one chart.

[justadogistaken]

Okay, I understand what you mean. But in this case, we need to know that the (registry. images) for app1 has been specified in parent values.yaml, Right? What if user assign the app1 (registry. images) in subcharts only? I think it will igonre the image.

[tgfree7]

Okay, I understand what you mean. But in this case, we need to know that the (registry. images) for app1 has been specified in parent values.yaml, Right? What if user assign the app1 (registry. images) in subcharts only? I think it will igonre the image.

If user assign the app1 (registry. images) in subcharts only, helm render will use the subcharts' setting.
The subcharts_and_globals shows the details.

[codecov-commenter]

Codecov Report

Base: 18.06% // Head: 18.41% // Increases project coverage by +0.35% 🎉

Coverage data is based on head (2e7e155) compared to base (47f8ada).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
+ Coverage   18.06%   18.41%   +0.35%     
==========================================
  Files          66       66              
  Lines        5354     5354              
==========================================
+ Hits          967      986      +19     
+ Misses       4265     4242      -23     
- Partials      122      126       +4     

Impacted Files	Coverage Δ
build/layerutils/charts/helm.go	44.18% <0.00%> (+44.18%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[justadogistaken]

Okay, I understand what you mean. But in this case, we need to know that the (registry. images) for app1 has been specified in parent values.yaml, Right? What if user assign the app1 (registry. images) in subcharts only? I think it will igonre the image.

If user assign the app1 (registry. images) in subcharts only, helm render will use the subcharts' setting. The subcharts_and_globals shows the details.

Yes, helm will render, but the render logic in sealer will do the same thing? Could you help confirm this? Write a test for this part will be perfect.

[tgfree7]

Okay, I understand what you mean. But in this case, we need to know that the (registry. images) for app1 has been specified in parent values.yaml, Right? What if user assign the app1 (registry. images) in subcharts only? I think it will igonre the image.

If user assign the app1 (registry. images) in subcharts only, helm render will use the subcharts' setting. The subcharts_and_globals shows the details.

Yes, helm will render, but the render logic in sealer will do the same thing? Could you help confirm this? Write a test for this part will be perfect.

Yes, i confirm that RenderHelmChart will render in the same way,and i will write a test for the RenderHelmChart.

[justadogistaken]

@tgfree7 Thanks for your work. I think you can create test samples(subchart included and excluded). And call the function of sealer, check the expected content.

[tgfree7]

@tgfree7 Thanks for your work. I think you can create test samples(subchart included and excluded). And call the function of sealer, check the expected content.

In the test case, where the chart should i store? in the sealer's path test ? I reivew the old test case, the chart ./test/alpine are not found.

[justadogistaken]

@tgfree7 You can create a testfile dir under the build or buildimage.

[tgfree7]

@tgfree7 You can create a testfile dir under the build or buildimage.

test case added.

[justadogistaken]

There is license problem.
make install-addlicense && make filelicense
Could you plz try this command?
And Probably the install-addlicense will fail, in that case, you can try install it yourself, and do make filelicense.

[tgfree7]

There is license problem. make install-addlicense && make filelicense Could you plz try this command? And Probably the install-addlicense will fail, in that case, you can try install it yourself, and do make filelicense.

ok, license added.

[justadogistaken]

LGTM
@kakaZhou719 Help check this work.