Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure overlay loaded #1701

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Sep 13, 2022

Describe what this PR does / why we need it

To ensure overlay loaded

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@YTGhost YTGhost force-pushed the ensure-overlay-loaded branch from d472385 to c6b6fb9 Compare September 13, 2022 09:12
@justadogistaken
Copy link
Member

@YTGhost check the problem. I guess you didn't import the lib.

@YTGhost
Copy link
Member Author

YTGhost commented Sep 13, 2022

@YTGhost check the problem. I guess you didn't import the lib.

Yep, I thought goland auto-imported for me

@YTGhost YTGhost force-pushed the ensure-overlay-loaded branch from c6b6fb9 to e626a9b Compare September 13, 2022 10:50
@codecov-commenter
Copy link

Codecov Report

Base: 18.44% // Head: 18.44% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e626a9b) compared to base (74be985).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
- Coverage   18.44%   18.44%   -0.01%     
==========================================
  Files          66       66              
  Lines        5346     5347       +1     
==========================================
  Hits          986      986              
- Misses       4234     4235       +1     
  Partials      126      126              
Impacted Files Coverage Δ
utils/mount/overlay2.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@justadogistaken
Copy link
Member

LGTM

@justadogistaken justadogistaken merged commit 8f8d8bc into sealerio:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants