Fix: cmd rmi images with flags #1711
Conversation
Codecov ReportBase: 18.39% // Head: 18.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1711 +/- ##
=======================================
Coverage 18.39% 18.39%
=======================================
Files 66 66
Lines 5359 5359
=======================================
Hits 986 986
Misses 4247 4247
Partials 126 126 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: tgfree <[email protected]> Fix: cmd rmi images with flags Signed-off-by: tgfree <[email protected]>
tgfree7
force-pushed
the
bugfix/images-rmi-args
branch
from
a1d566a to
de9ab40
Compare
|
@justadogistaken I find out, defer func() {
err = os.RemoveAll(tmpDir)
if err != nil {
logrus.Warnf("failed to rm link dir to rootfs: %v : %v", tmpDir, err)
}
}()Did sealer still need the cmd |
Signed-off-by: tgfree <[email protected]>
|
|
||
| force removal of the image and any containers using the image: | ||
| sealer rmi registry.cn-qingdao.aliyuncs.com/sealer-io/kubernetes:v1.19.8 --force/-f | ||
|
|
There was a problem hiding this comment.
No need for -f flag example?
There was a problem hiding this comment.
I notice there is a empty line.
I'm not sure if the content is exhibited correctly in my machine.
Signed-off-by: tgfree [email protected]
Describe what this PR does / why we need it
try to fix sealer rmi with flag error
Does this pull request fix one issue?
#1710
Describe how you did it
Describe how to verify it
Special notes for reviews