Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize cluster runtime #1769

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

kakaZhou719
Copy link
Member

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

  1. optimize cluster runtime : move out uninstall and scale process
  2. load registry data from cluster image if its type is app-installer.

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Base: 20.55% // Head: 20.50% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (f05a4a0) compared to base (9d4f590).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
- Coverage   20.55%   20.50%   -0.05%     
==========================================
  Files          69       71       +2     
  Lines        6525     6540      +15     
==========================================
  Hits         1341     1341              
- Misses       5003     5018      +15     
  Partials      181      181              
Impacted Files Coverage Δ
pkg/cluster-runtime/installer.go 0.00% <0.00%> (ø)
pkg/cluster-runtime/scale.go 0.00% <0.00%> (ø)
pkg/cluster-runtime/uninstall.go 0.00% <0.00%> (ø)
pkg/cluster-runtime/utils.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

update reviews: upload container image to registry by driver when install app
@kakaZhou719 kakaZhou719 force-pushed the optimize-cluster-runtime branch from c1f4330 to 00f75ac Compare October 14, 2022 07:26
@starnop
Copy link
Collaborator

starnop commented Oct 14, 2022

LGTM

@starnop starnop merged commit 0aca85f into sealerio:main Oct 14, 2022
@kakaZhou719 kakaZhou719 deleted the optimize-cluster-runtime branch March 8, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants