Fix some bugs #1795
Merged
Fix some bugs #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. support '|' for hook's scope 2. fix clean /var/lib/kubelet device busy bug. Signed-off-by: huaiyou <[email protected]>
Codecov ReportBase: 20.65% // Head: 20.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
==========================================
- Coverage 20.65% 20.61% -0.04%
==========================================
Files 71 71
Lines 6545 6557 +12
==========================================
Hits 1352 1352
- Misses 5012 5024 +12
Partials 181 181
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kakaZhou719
reviewed
Oct 24, 2022
pkg/cluster-runtime/hook.go
Outdated
| @@ -151,6 +151,24 @@ func (i *Installer) runClusterHook(master0 net.IP, phase Phase) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // runClusterHook run cluster scope hook by Phase that means will only execute hook on master0. | |||
There was a problem hiding this comment.
pls add new comments for this func.
Signed-off-by: huaiyou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: huaiyou [email protected]
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews