support cluster scale up via sealer apply cli #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 21.75% // Head: 21.75% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1818 +/- ##
=======================================
Coverage 21.75% 21.75%
=======================================
Files 72 72
Lines 6554 6554
=======================================
Hits 1426 1426
Misses 4942 4942
Partials 186 186 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kakaZhou719
force-pushed
the
add-scalup-to-sealer-apply
branch
2 times, most recently
from
fb8a5f9 to
1332474
Compare
|
@kakaZhou719 Resolve conflict. |
kakaZhou719
force-pushed
the
add-scalup-to-sealer-apply
branch
from
1332474 to
2f35650
Compare
VinceCui
reviewed
Nov 1, 2022
cmd/sealer/cmd/cluster/apply.go
Outdated
| infraDriver, err := infradriver.NewInfraDriver(&cluster) | ||
| if err != nil { | ||
| return err | ||
| if !osi.IsFileExist(common.DefaultKubeConfigFile()) { |
There was a problem hiding this comment.
You can check if k8s exists here, more security.
There was a problem hiding this comment.
init k8s client to check ?
kakaZhou719
force-pushed
the
add-scalup-to-sealer-apply
branch
from
9c36d33 to
e02ba08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews