Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multi-platform build #1820

Merged
merged 4 commits into from
Nov 9, 2022
Merged

support multi-platform build #1820

merged 4 commits into from
Nov 9, 2022

Conversation

justadogistaken
Copy link
Member

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@justadogistaken
Copy link
Member Author

For multi-platform image, it's actually a manifest list.
It's still needs to be handled.
But the multi-platform build had been supported.
You'd better check how buildah support manifest push remove.

@justadogistaken justadogistaken force-pushed the feature/multi-platform-build branch from bd623a2 to 23d4f6e Compare October 27, 2022 02:24
@github-actions github-actions bot added Clusterfile ImageBuilding related to all staff with image building test labels Oct 27, 2022
@justadogistaken justadogistaken force-pushed the feature/multi-platform-build branch 3 times, most recently from 5937c66 to 0b45ec8 Compare October 27, 2022 11:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Base: 21.65% // Head: 21.65% // No change to project coverage 👍

Coverage data is based on head (9e368e6) compared to base (d744765).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1820   +/-   ##
=======================================
  Coverage   21.65%   21.65%           
=======================================
  Files          72       72           
  Lines        6586     6586           
=======================================
  Hits         1426     1426           
  Misses       4974     4974           
  Partials      186      186           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@starnop
Copy link
Collaborator

starnop commented Nov 7, 2022

@justadogistaken cloud you please rebase the commits for this PR

image

@kakaZhou719
Copy link
Member

@justadogistaken cloud you please rebase the commits for this PR

image

@starnop ,let me do it, some rebase commits was pushed by me.

support multi-platform build

add sealer manifest cmd to support multi platform image
@kakaZhou719 kakaZhou719 force-pushed the feature/multi-platform-build branch 2 times, most recently from 8968b6f to 1bf13be Compare November 8, 2022 01:40
@kakaZhou719 kakaZhou719 force-pushed the feature/multi-platform-build branch from 1bf13be to b289eb6 Compare November 8, 2022 06:31
@kakaZhou719
Copy link
Member

for manifest object:
sealer manifest create localhost/my-manifest
sealer manifest add localhost/my-manifest localhost/ack-distro-amd64:v1
sealer manifest inspect localhost/my-manifest
sealer manifest push localhost/my-manifest
sealer manifest remove localhost/my-manifest sha256:be14feecd1103bdb28db7f7d09ad3ee56f7afc0bb4ddf5f0284e9dc0158e9a49
sealer manifest delete localhost/my-manifest

for mutil-arch image:
sealer build -f Kubefile -t docker.io/sealer/my-kubernetes:1.19.8 --platform linux/amd64,linux/arm64
sealer push docker.io/sealer/my-kubernetes:1.19.8 --all: push all platform image
sealer push docker.io/sealer/my-kubernetes:1.19.8: push default platform image
sealer pull docker.io/sealer/my-kubernetes:1.19.8 --platform linux/arm64

for single-arch image:
sealer build -f Kubefile -t my-kubernetes:1.19.8
sealer push my-kubernetes:1.19.8
sealer pull docker.io/sealer/my-kubernetes:1.19.8

@starnop starnop merged commit 45802b9 into main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clusterfile ImageBuilding related to all staff with image building test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants