Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:sealer run bug #1825

Merged
merged 2 commits into from
Oct 31, 2022
Merged

fix:sealer run bug #1825

merged 2 commits into from
Oct 31, 2022

Conversation

Stevent-fei
Copy link
Collaborator

@Stevent-fei Stevent-fei commented Oct 28, 2022

Describe what this PR does / why we need it

Fix the sealer run command failure
image

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@@ -45,11 +47,11 @@ will apply the diff change of current Clusterfile and the original one.`,
err error
)

if clusterFile == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you delete the "clusterFile"?

@codecov-commenter
Copy link

Codecov Report

Base: 21.75% // Head: 21.71% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (a5a129f) compared to base (f21cbb8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   21.75%   21.71%   -0.04%     
==========================================
  Files          72       72              
  Lines        6554     6566      +12     
==========================================
  Hits         1426     1426              
- Misses       4942     4954      +12     
  Partials      186      186              
Impacted Files Coverage Δ
pkg/clusterfile/clusterfile.go 34.44% <0.00%> (-5.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stevent-fei Stevent-fei changed the title fix:sealer run failed fix:sealer run bug Oct 31, 2022
@Stevent-fei Stevent-fei merged commit c854d89 into sealerio:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants