support only load image apply mode #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 21.65% // Head: 21.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
=======================================
Coverage 21.65% 21.65%
=======================================
Files 72 72
Lines 6586 6586
=======================================
Hits 1426 1426
Misses 4974 4974
Partials 186 186 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Stevent-fei
force-pushed
the
support_load_image
branch
from
033fd9a to
ade4521
Compare
starnop
reviewed
Nov 13, 2022
cmd/sealer/cmd/cluster/apply.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if err := distributor.DistributeRegistry(infraDriver.GetHostIPList()[0], infraDriver.GetClusterRootfsPath()); err != nil { |
There was a problem hiding this comment.
if applyMode == common.ApplyModeLoadImage {
if err := distributor.DistributeRegistry(infraDriver.GetHostIPList()[0], infraDriver.GetClusterRootfsPath());err!=nil{}
return nil
}
There was a problem hiding this comment.
Is it possible to implement the loadImage apply mode by the above few lines of code?
Stevent-fei
force-pushed
the
support_load_image
branch
from
5bbc1fc to
3eb1e45
Compare
starnop
approved these changes
Nov 15, 2022
Stevent-fei
added a commit
to Stevent-fei/sealer
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
In special scenarios, we want to load images to the specified registry in advance.
This PR try to support the above feature by do these things:
add apply mode flag
support only loadImage apply mode
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews