add --image-list imageList #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Stevent-fei ，i am ok with this logic, while i thought could we unify the download container image logic here. for example : grab all images list we needed via walking build context, and then download everyone. |
starnop
reviewed
Nov 30, 2022
| @@ -253,19 +256,37 @@ func applyRegistryToImage(imageID, tag, manifest string, platform v1.Platform, e | |||
| return errors.Wrapf(err, "failed to create working container, imageid: %s", imageID) | |||
| } | |||
|
|
|||
| // download container image form `imageList` | |||
There was a problem hiding this comment.
merge with code
if err := buildimage.NewMiddlewarePuller(v1.Platform{
Architecture: arch,
OS: _os,
Variant: variant,
......
jsparter
pushed a commit
to jsparter/sealer
that referenced
this pull request
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
add imageList Flag to sealer build to support download extra container image rather than copy it to rootfs,Provide additional image download method.
eg:
sealer build -t abc:v1 --image-list imageList
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews