Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shell type for APP instruction #1885

Merged

Conversation

kakaZhou719
Copy link
Member

Describe what this PR does / why we need it

sometimes when installing an app type cluster image, we need to configure some additional information. such as some k8s cluster resources which cannot be directly written in the yaml file as fixed value.

if so, we nee add shell type for APP instruction, and it does not affect the current usage.

for shell :

  1. if local file is normal file and the suffix of this file ends with a ".sh", will copy it to rootfs ,and write its launch cmd in sealer image extension at build stage.
  2. if local file is dir, will walk though the target dir , and collect all files which suffix is ends with a ".sh", then write its launch cmd in sealer image extension at build stage.

below is my test kubefile:

FROM scratch
APP config local://config.sh
APP my-shell local://shell 
APP dashboard local://dashboard.yaml
LAUNCH ["config","my-shell","dashboard"]

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@github-actions github-actions bot added ImageBuilding related to all staff with image building test labels Nov 22, 2022
@kakaZhou719 kakaZhou719 force-pushed the feat-add-shell-type-for-app-instruction branch from c7239c8 to 7ff3358 Compare November 22, 2022 08:36
@kakaZhou719 kakaZhou719 linked an issue Nov 22, 2022 that may be closed by this pull request
@kakaZhou719 kakaZhou719 force-pushed the feat-add-shell-type-for-app-instruction branch from 7ff3358 to bed87fc Compare November 22, 2022 09:47
@kakaZhou719 kakaZhou719 merged commit dea2484 into sealerio:main Nov 22, 2022
@kakaZhou719 kakaZhou719 deleted the feat-add-shell-type-for-app-instruction branch June 28, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImageBuilding related to all staff with image building test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] support shell for app
2 participants