set lvscare health path and health schem for registry server #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakaZhou719
force-pushed
the
bugfix-set-lvscare-healthPath-for-registry
branch
2 times, most recently
from
1f654c3 to
9814c45
Compare
Codecov ReportBase: 17.56% // Head: 17.56% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1926 +/- ##
=======================================
Coverage 17.56% 17.56%
=======================================
Files 103 103
Lines 9113 9113
=======================================
Hits 1601 1601
Misses 7299 7299
Partials 213 213
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
VinceCui
reviewed
Dec 21, 2022
| @@ -191,7 +191,8 @@ func (k *Runtime) configureLvs(masterHosts, clientHosts []net.IP) error { | |||
| } | |||
| vs := net.JoinHostPort(k.getAPIServerVIP().String(), "6443") | |||
| ipvsCmd := fmt.Sprintf("seautil ipvs --vs %s %s --health-path /healthz --health-schem https --run-once", vs, strings.Join(rs, " ")) | |||
kakaZhou719
force-pushed
the
bugfix-set-lvscare-healthPath-for-registry
branch
2 times, most recently
from
5546307 to
cfda4e5
Compare
set lvscare health path for registry server
kakaZhou719
force-pushed
the
bugfix-set-lvscare-healthPath-for-registry
branch
from
cfda4e5 to
668b9f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
for registry server health path :choose "/" as default.
for registry server health schem: if registry deployed as insecure mode, health schem is "http", otherwise ,it is "https".
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews