Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update concurrent for some logic #1928

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

starnop
Copy link
Collaborator

@starnop starnop commented Dec 21, 2022

Signed-off-by: yuxing.lyx [email protected]

Describe what this PR does / why we need it

We need to be more explicit about when we should use concurrency, and when using concurrency actually increases our chances of making mistakes. In this PR, I update these things:

  1. set the concurrency of pull image is set to 1 because the bottleneck of downloading images is often in the network rather than computing resources
  2. copy the registry to other master nodes, we will copy lots of small files and the bottleneck of copy registry is not in the network so we can copy multi nodes concurrently

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Base: 17.56% // Head: 17.55% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (ed0bd2e) compared to base (bc97de4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1928      +/-   ##
==========================================
- Coverage   17.56%   17.55%   -0.02%     
==========================================
  Files         103      103              
  Lines        9113     9120       +7     
==========================================
  Hits         1601     1601              
- Misses       7299     7306       +7     
  Partials      213      213              
Impacted Files Coverage Δ
pkg/image/save/save.go 0.00% <ø> (ø)
pkg/imagedistributor/scp_distributor.go 0.00% <0.00%> (ø)
pkg/ipvs/ipvs.go 79.66% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@starnop starnop force-pushed the optimize-concurrent-logic branch from f843ce4 to ed0bd2e Compare December 22, 2022 03:18
Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakaZhou719 kakaZhou719 merged commit c5c90a2 into sealerio:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants