Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: check image blob save and retry if not exist #1931

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

starnop
Copy link
Collaborator

@starnop starnop commented Dec 22, 2022

Signed-off-by: yuxing.lyx [email protected]

Describe what this PR does / why we need it

check if the blob files for image is complete and retry to get if not

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Base: 17.55% // Head: 17.51% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (a32fb09) compared to base (6288d3d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1931      +/-   ##
==========================================
- Coverage   17.55%   17.51%   -0.04%     
==========================================
  Files         103      103              
  Lines        9120     9139      +19     
==========================================
  Hits         1601     1601              
- Misses       7306     7325      +19     
  Partials      213      213              
Impacted Files Coverage Δ
pkg/image/save/save.go 0.00% <0.00%> (ø)
pkg/imagedistributor/scp_distributor.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakaZhou719 kakaZhou719 merged commit ce78d61 into sealerio:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants