Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: enrich kubefile #1980

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Conversation

starnop
Copy link
Collaborator

@starnop starnop commented Jan 15, 2023

Signed-off-by: yuxing.lyx [email protected]

Describe what this PR does / why we need it

Add CNI, CRI, LABEL,KUBEVERSION instruction for Kubefile

Does this pull request fix one issue?

Partial fixes #1968

Describe how you did it

Describe how to verify it

Special notes for reviews

@github-actions github-actions bot added ImageBuilding related to all staff with image building test labels Jan 15, 2023
@starnop starnop force-pushed the enrich-kubefile branch 3 times, most recently from 32e723b to 9ce557b Compare January 15, 2023 14:51
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Base: 17.51% // Head: 17.70% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (c0d61a3) compared to base (05a9c6c).
Patch coverage: 52.56% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
+ Coverage   17.51%   17.70%   +0.18%     
==========================================
  Files         103      103              
  Lines        9184     9244      +60     
==========================================
+ Hits         1609     1637      +28     
- Misses       7362     7394      +32     
  Partials      213      213              
Impacted Files Coverage Δ
pkg/define/image/v1/sealer_image_extension.go 0.00% <0.00%> (ø)
build/kubefile/parser/kubefile.go 47.80% <6.89%> (-8.05%) ⬇️
build/kubefile/parser/app_handler.go 45.94% <28.57%> (ø)
pkg/imageengine/buildah/inspect.go 25.26% <85.71%> (+25.26%) ⬆️
build/kubefile/parser/parse.go 55.77% <100.00%> (+0.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@starnop starnop force-pushed the enrich-kubefile branch 2 times, most recently from c0d61a3 to 2d4aa3b Compare January 16, 2023 03:51
Signed-off-by: yuxing.lyx <[email protected]>
Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakaZhou719 kakaZhou719 merged commit 91ba640 into sealerio:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImageBuilding related to all staff with image building test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add more instructions to enrich the Kubefile's capabilities
3 participants