feat:support multi arch for load and save #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 18.64% // Head: 18.35% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2062 +/- ##
==========================================
- Coverage 18.64% 18.35% -0.29%
==========================================
Files 99 99
Lines 9179 9322 +143
==========================================
Hits 1711 1711
- Misses 7243 7386 +143
Partials 225 225
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
starnop
reviewed
Feb 27, 2023
| // delete it if manifestName is already used | ||
| _, err = engine.ImageRuntime().LookupManifestList(manifestName) | ||
| if err == nil { | ||
| delErr := engine.DeleteManifests([]string{manifestName}, &options.ManifestDeleteOpts{}) |
starnop
reviewed
Feb 27, 2023
| if err != nil { | ||
| return fmt.Errorf("failed to create new manifest %s :%v ", manifestName, err) | ||
| } | ||
|
|
There was a problem hiding this comment.
defer deleting manifest if err not equals nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
support multi arch for load and save, no need to care about the image arch.
save: could save with id Or name.
sealer save bf5e56e64dd9 -o abc.tarsealer save abc:v1 -o abc.tarload:
sealer load -i abc.tarDoes this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews