feat: support pack different arch image together #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ImageBuilding
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
==========================================
- Coverage 20.19% 13.09% -7.10%
==========================================
Files 98 263 +165
Lines 9100 22634 +13534
==========================================
+ Hits 1838 2965 +1127
- Misses 7008 19264 +12256
- Partials 254 405 +151
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cubxxw
approved these changes
Apr 14, 2023
starnop
reviewed
Apr 21, 2023
pkg/imageengine/buildah/manifest.go
Outdated
| //getImageId get imageID by name Or id,what ever it is an image or a manifest | ||
| // if it is image just return imageID | ||
| // if it is a manifest, return its included instance IDs. | ||
| func (engine *Engine) getImageID(imageNameOrID string) ([]string, error) { |
There was a problem hiding this comment.
s/getImageID/getImageIDList
starnop
reviewed
Apr 21, 2023
cmd/sealer/cmd/alpha/manifest.go
Outdated
| @@ -140,6 +131,7 @@ func manifestAddCommand() *cobra.Command { | |||
| flags.StringSliceVar(&addManifestOpts.OsFeatures, "os-features", nil, "override the OS `features` of the specified image") | |||
| flags.StringSliceVar(&addManifestOpts.Annotations, "annotation", nil, "set an `annotation` for the specified image") | |||
| flags.BoolVar(&addManifestOpts.All, "all", false, "add all of the list's images if the image is a list") | |||
| flags.StringVarP(&addManifestOpts.TargetImageName, "target-image", "t", "", "target image name,if it is not exist,will create a new one") | |||
There was a problem hiding this comment.
how about using target here?
kakaZhou719
force-pushed
the
feat-support-merge-image
branch
from
615bb15 to
b1a8b07
Compare
feat: support pack different arch image together
kakaZhou719
force-pushed
the
feat-support-merge-image
branch
from
b1a8b07 to
147825b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
sealer alpha manifest add amd:v1 arm:v1 -t all-in-one:v1-t flag: specify the wanted new image name, if null, will create a new one. if not null, it must be an existed manifest name.args: if it is a single image just add it ,if it is a manifest will add it’s s all instance no matter what platform it is.Does this pull request fix one issue?
Fixes #2180
Describe how you did it
Describe how to verify it
Special notes for reviews