Implement XOVER support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XOVER was the original OVER. When XOVER went from being experimental to an accepted standard, the X was removed. Older servers support XOVER and not OVER. Since XOVER and OVER have the same implementation, the only difference being the command line sent to the server, this pull request implements a solution that does just that. If the caller wants to use OVER, "OVER" is sent to the server. If the caller wants to use XOVER, "XOVER" is sent to the server. The return from both calls is the same - a read only collection of OverResults. (That is, I didn't implement an XOverResults.)