-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uninit headers - second approach #98
Conversation
@seanmonstar do we consider bumping minimal rustc version, like in |
https://crates.io/crates/maybe-uninit would let you support at least Rust 1.20 while ensuring soundness on Rust 1.36+. Even older versions of Rust do not really have any good way to work with uninit data correctly. If they still need to be supported, possibly a feature flag could be used to provide this API only when the user asks for it? I will note though that Rust 1.20 is already ancient, it was released 4 years ago. |
Ok, let's work on this! First thing I did was get CI moved from Travis to GH Actions. For MSRV, it's probably fine we just bump it to 1.36. It's two years old at this point! |
A force-pushed empty commit would restart CI? |
Hm, probably a rebase of master. |
ugh, sorry for the wait, git didn't want to cooperate with me -_- |
Yea, so the new CI is failing the msrv job. You can just update the yaml file to set the new MSRV. |
Previous attempt: #97
Fixes: #95 and #58