Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninit headers - second approach #98

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

Soveu
Copy link
Contributor

@Soveu Soveu commented May 12, 2021

Previous attempt: #97
Fixes: #95 and #58

@Soveu
Copy link
Contributor Author

Soveu commented May 12, 2021

@seanmonstar do we consider bumping minimal rustc version, like in hyper? Looks like CI is failing (mainly) because of no MaybeUninit in 1.10

@Soveu
Copy link
Contributor Author

Soveu commented May 26, 2021

@seanmonstar ?

@RalfJung
Copy link
Contributor

Looks like CI is failing (mainly) because of no MaybeUninit in 1.10

https://crates.io/crates/maybe-uninit would let you support at least Rust 1.20 while ensuring soundness on Rust 1.36+.

Even older versions of Rust do not really have any good way to work with uninit data correctly. If they still need to be supported, possibly a feature flag could be used to provide this API only when the user asks for it? I will note though that Rust 1.20 is already ancient, it was released 4 years ago.

@seanmonstar
Copy link
Owner

Ok, let's work on this! First thing I did was get CI moved from Travis to GH Actions.

For MSRV, it's probably fine we just bump it to 1.36. It's two years old at this point!

@Soveu
Copy link
Contributor Author

Soveu commented Jul 23, 2021

A force-pushed empty commit would restart CI?

@seanmonstar
Copy link
Owner

Hm, probably a rebase of master.

@Soveu
Copy link
Contributor Author

Soveu commented Aug 2, 2021

ugh, sorry for the wait, git didn't want to cooperate with me -_-

@seanmonstar
Copy link
Owner

Yea, so the new CI is failing the msrv job. You can just update the yaml file to set the new MSRV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need for Request to take a slice of MaybeUninit<Header>
3 participants