Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssl tests (this is just to test against the CI) #136

Closed
wants to merge 4 commits into from

Conversation

little-dude
Copy link
Contributor

I think I fixed the hang.
The tests still fail sometimes though.

 - test custom root certificate
 - test custom root certificate with hostname verification disabled
@little-dude
Copy link
Contributor Author

so locally (linux), I have a 10% failure rate but travis consistently fails one of the tests.

@seanmonstar
Copy link
Owner

So, I have a couple thoughts that may make it easier to get things passing:

  1. I see the port 12345 specified in the test, but no where else. It seems like the port doesn't need to be specific, and so to prevent concerns with the port being busy in the next tests, it could be better to use a port of 0, and then after the listener is bound, grap the local addr to check what port is being used.
  2. I actually wouldn't use a hyper server for this. It doesn't have the ability to shutdown (listening.close() is a lie).
  3. Instead of panic!(e), try panic!("{:?}", e). The message should be better, hopefully.

@seanmonstar
Copy link
Owner

I'm going to close as in-active.

repi pushed a commit to EmbarkStudios/reqwest that referenced this pull request Dec 20, 2019
This issue is related to seanmonstar#88 and would prevent issues like it when
openssl 1.2 comes out.

This commit adds support for building reqwest with rustls support, using
the new feature flag `rustls`.

This fixes seanmonstar#136.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants