refactor: call system gc once instead of after each job cleanup iteration #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
druwadi
previously approved these changes
Jul 25, 2022
josegonzalez
force-pushed
the
safer-cleanup
branch
from
e3bb89e to
ca7a445
Compare
…tion When cleaning up a namespace, we previously: - purged the ignorable jobs - called system gc - called namespace deletion This was performed for each namespace, causing more load on Nomad as it called GC potentially dozens of times. Instead, we now purged all the ignorable jobs in each namespace, _then_ call system gc, and finally delete all the underlying namespaces. This should cause less stress on the nomad cluster. Additionally, if no jobs are found for a deletable namespace, skip the deletion logic completely (which makes the log output a bit cleaner).
josegonzalez
force-pushed
the
safer-cleanup
branch
from
ca7a445 to
57b368b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cleaning up a namespace, we previously:
This was performed for each namespace, causing more load on Nomad as it called GC potentially dozens of times.
Instead, we now purged all the ignorable jobs in each namespace, then call system gc, and finally delete all the underlying namespaces. This should cause less stress on the nomad cluster.
Additionally, if no jobs are found for a deletable namespace, skip the deletion logic completely (which makes the log output a bit cleaner).