Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL length is limited to about 140 characters #8

Closed
ockam opened this issue Feb 21, 2018 · 7 comments
Closed

URL length is limited to about 140 characters #8

ockam opened this issue Feb 21, 2018 · 7 comments
Labels

Comments

@ockam
Copy link

ockam commented Feb 21, 2018

When using URL longer than around 140 characters, I get a validation error stating that the field in longer than 255 characters.

I’m currently on C3 RC11.

@ockam
Copy link
Author

ockam commented Feb 21, 2018

Just found out that linkfiled store a json object in a varchar(255), which explain its limit and the error.

May I suggest using a text field instead.

@nfourtythree
Copy link
Contributor

@ockam I have submitted a pull request #9 to get this updated. Hopefully will be merged in soon, if not you can install from my fork

@ockam
Copy link
Author

ockam commented Feb 22, 2018

@nfourtythree cool! But doesn’t it require a migration to update current install? (I’m a noob regarding plugins....)

@nfourtythree
Copy link
Contributor

nfourtythree commented Feb 22, 2018

@ockam just give it a test and if you go into settings > fields, head to your field and just resave the settings, it updates the column type in the DB and from my test kept all the data fine*.

*your mileage may vary and I am not responsible for any data loss! 🔒

@ockam
Copy link
Author

ockam commented Feb 22, 2018

Thanks.

@sebastian-lenz are you considering accepting pull request #9?
(don’t mean to put pressure on you, just want to know where you’re heading. :) )

sebastian-lenz added a commit that referenced this issue Feb 23, 2018
[Added] Added TYPE_TEXT column type to avoid DB save errors fixes #8
@sebastian-lenz
Copy link
Owner

Thanks for the pull request @nfourtythree!

@nfourtythree
Copy link
Contributor

No problem @sebastian-lenz, always happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants