Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add additional newline to unified diff when completely empty #99

Merged

Conversation

znbailey
Copy link
Contributor

@znbailey znbailey commented May 7, 2020

Fixes #98

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #99   +/-   ##
=========================================
  Coverage     99.11%   99.11%           
- Complexity      211      212    +1     
=========================================
  Files            12       12           
  Lines           563      563           
=========================================
  Hits            558      558           
  Misses            5        5           
Impacted Files Coverage Δ Complexity Δ
src/Output/UnifiedDiffOutputBuilder.php 99.07% <100.00%> (ø) 37.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249d2b1...eadc841. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit be1410b into sebastianbergmann:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in unified diff output of identical strings between 2.x and 3.x
2 participants