Skip to content

Commit

Permalink
fix comment
Browse files Browse the repository at this point in the history
  • Loading branch information
staabm authored and sebastianbergmann committed Nov 2, 2024
1 parent 536645d commit 71215c7
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/Runner/PHPT/PhptTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ private function shouldRunInSubprocess(array $sections, string $cleanCode): bool
foreach ($sideEffects as $sideEffect) {
if (
$sideEffect === SideEffect::STANDARD_OUTPUT || // stdout is fine, we will catch it using output-buffering
$sideEffect === SideEffect::INPUT_OUTPUT // IO is fine while cleanup, as it doesn't pollute the main process
$sideEffect === SideEffect::INPUT_OUTPUT // IO is fine, as it doesn't pollute the main process
) {
continue;
}
Expand Down
2 changes: 1 addition & 1 deletion tests/end-to-end/_files/phpt-skipif-require.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
--TEST--
PHPT skip condition with IO operations run in main process
PHPT skip condition with require() runs in subprocess
--SKIPIF--
<?php declare(strict_types=1);
require (__DIR__ . '/phpt-skipif-required-file.php');
Expand Down
15 changes: 12 additions & 3 deletions tests/end-to-end/_files/phpt-skipif-required-file.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
<?php

<?php declare(strict_types=1);
/*
* This file is part of PHPUnit.
*
* (c) Sebastian Bergmann <[email protected]>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace PhpTSkipIfRequiredFile;

class SomeClass {}
class SomeClass
{
}

0 comments on commit 71215c7

Please sign in to comment.