Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5567 #5569

Closed
wants to merge 2 commits into from
Closed

Fix issue #5567 #5569

wants to merge 2 commits into from

Conversation

ptomulik
Copy link
Contributor

Fixes #5567.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e57e12a) 88.28% compared to head (a8355d7) 88.19%.
Report is 110 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5569      +/-   ##
============================================
- Coverage     88.28%   88.19%   -0.09%     
+ Complexity     6337     6309      -28     
============================================
  Files           678      676       -2     
  Lines         20223    20225       +2     
============================================
- Hits          17853    17838      -15     
- Misses         2370     2387      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptomulik ptomulik force-pushed the issue-5567 branch 2 times, most recently from 597653e to 2450f6a Compare November 20, 2023 00:06
@ptomulik ptomulik changed the base branch from main to 10.4 November 20, 2023 00:20
@ptomulik ptomulik changed the title fix issue #5567 Fix issue #5567 Nov 20, 2023
@sebastianbergmann sebastianbergmann deleted the branch sebastianbergmann:10.4 November 27, 2023 12:35
@sebastianbergmann
Copy link
Owner

I am sorry that this was automatically closed. Can you please send this again for the 10.5 branch? Thanks!

@ptomulik
Copy link
Contributor Author

I am sorry that this was automatically closed. Can you please send this again for the 10.5 branch? Thanks!

Np. Re-created this as #5590 (against 10.5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants