Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake support #5

Merged
merged 6 commits into from
Jun 30, 2016
Merged

cmake support #5

merged 6 commits into from
Jun 30, 2016

Conversation

fbergmann
Copy link
Collaborator

Hello,

I really liked your project. However, I needed it to work across platforms. So I added a CMake files to it. Then I noticed that the std::experimental::filesystem had some changes on VS2015 and added the change. Then I noticed that on Linux / Mac there is no support for it right now, so i added support for either using the boost filesystem api, or the qt core library. Remaining chanes are about changes from backslashes to slashes.

Sorry for the whitespace changes.

best
Frank

…ears not to be a constructor that takes a string), instead of std::exception a runtime_exception will be thrown ...

- removed some warnings
- add exception_class to defs.h, so that different exceptions canbe thrown
- fix the path
$ENV{ZLIBROOT}/include
DOC "The directory containing the zlib include files."
)
endif()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im no cmake expert at all, but this if (NOT LIBZ_INCLUDE_DIR)looks like its duplicated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is in the use of the NO_DEFAULT_PATH, basically I want to make sure that I really take the one that I have provided rather than another one that is found. That was needed in another project I'm involved with. more information below.

  1. https://cmake.org/cmake/help/v3.0/command/find_path.html

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, then this is good to go i guess. Thanks a lot!

@sebastiandev
Copy link
Owner

@fbergmann I'm glad you liked it.
This looks great!
Thanks for the improvements.

@sebastiandev sebastiandev merged commit 91c53c2 into sebastiandev:master Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants