Skip to content

Commit

Permalink
Improvement contributing.md (apache#10859)
Browse files Browse the repository at this point in the history
* Improvement contributing.md

* update
  • Loading branch information
zhaoyongjie authored Sep 14, 2020
1 parent 8a774d5 commit b4df053
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -325,17 +325,11 @@ For example, the image referenced above actually lives in `superset-frontend/ima

Make sure your machine meets the [OS dependencies](https://superset.incubator.apache.org/installation.html#os-dependencies) before following these steps.

Developers should use a virtualenv.

```bash
pip install virtualenv
```

Then proceed with:
Ensure Python versions >3.7, Then proceed with:

```bash
# Create a virtual environemnt and activate it (recommended)
virtualenv -p python3 venv # setup a python3.6 virtualenv
python3 -m venv venv # setup a python3 virtualenv
source venv/bin/activate

# Install external dependencies
Expand Down Expand Up @@ -648,7 +642,7 @@ Superset includes a [Storybook](https://storybook.js.org/) to preview the layout

```bash
cd superset-frontend
npm run storybool
npm run storybook
```

When contributing new React components to Superset, please try to add a Story alongside the component's `jsx/tsx` file.
Expand Down

0 comments on commit b4df053

Please sign in to comment.