Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (FuzzTests) Various fixes for #148 fuzz report. #152

Closed
wants to merge 4 commits into from

Conversation

jafin
Copy link
Contributor

@jafin jafin commented Sep 9, 2019

Changes to correct issues identified in #148 from the fuzz testing.

  • Guard on Modulo for required arguments.
  • Guard on remove for required arguments.
  • GetHashCode fix on NilValue which caused stackoverflow
  • Maths.Abs on StringValue GetIndex when it attempts to index negative values.
  • Parse check for missing start tag on 'for'
  • Throw Parser error on missing end tag
  • Fuzz test cases added

…#148  .  Filter expression guards are in place, but will throw a runtime error,  ideally this should materialize as a template validation error.
…tory argument via attribute and throw ParserException when invalid state.
…arserException, changed to ArgumentException.
… for StringValue using a negative index. Added test cases.
@sebastienros
Copy link
Owner

Thanks @jafin, I have pushed all the changes you handled here in a different commit that covers each test case individually.

@sebastienros
Copy link
Owner

Feel free to file more issues if you think I forgot something: 4931af9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants