Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add browser field to package.json #522

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

benmccann
Copy link
Contributor

About this Pull Request

  • What kind of change does this PR introduce? bug fix

  • What is the current behavior? doesn't work on cloudflare workers

  • What is the new behavior (if this is a feature change)? does work on cloudflare workers

  • Does this PR introduce a breaking change? no

  • Other information: as described in Export a browser version #511 (comment)

Pull Request Checklist

  • My code follows the code style of this project
    • Run npm run lint to double check
  • My change requires a change to the documentation
    • I have updated the documentation accordingly
  • I have added tests to cover my changes
    • Run npm run test to run the unit tests and npm run coverage to generate a coverage report
  • All new and existing tests passed
  • My commit messages follow the commit guidelines

You can prevent a module from being loaded into a bundle by specifying a value of false for that key. This is useful if you know certain codepaths will not be executed client side but find it awkward to split up or change the code structure.
@sebbo2002 sebbo2002 merged commit d9b1e28 into sebbo2002:develop Sep 20, 2023
@benmccann benmccann deleted the patch-2 branch September 20, 2023 04:41
@sebbo2002
Copy link
Owner

Thanks for your contribution 🙏🏼

@sebbo2002
Copy link
Owner

🎉 This PR is included in version 5.0.2-develop.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sebbo2002
Copy link
Owner

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants