Images for feed categories - new set and missing ones #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Images for categories missing from code · Issue #240 · seblucas/cops - #240 New set of images created. 64*64 px Tested on Android on light and dark backgrounds Color used: Color Hex #607b8b Light Sky Blue 4 - http://www.color-hex.com/color/607b8b Images are created from flaticon.com You can make new ones online from this links: http://www.flaticon.com/free-icon/user-silhouette_64096 http://www.flaticon.com/free-icon/books-piled-_14184 http://www.flaticon.com/free-icon/buildings_34271 http://www.flaticon.com/free-icon/signing-the-contract_66720 http://www.flaticon.com/free-icon/seo-tags_15564 http://www.flaticon.com/free-icon/abc-book_73353 http://www.flaticon.com/free-icon/small-wall-clock_3921 Creative Commons BY 3.0 Copyright notice for flaticon.com and freepik.com included in Cops (required by icons tool)
| @@ -418,7 +418,8 @@ class Entry | |||
| Book::ALL_RECENT_BOOKS_ID => 'images/recent.png', | |||
| Tag::ALL_TAGS_ID => 'images/tag.png', | |||
| Language::ALL_LANGUAGES_ID => 'images/language.png', | |||
| CustomColumn::ALL_CUSTOMS_ID => 'images/tag.png', | |||
| CustomColumn::ALL_CUSTOMS_ID => 'images/custom.png', | |||
| "cops:rating$" => 'images/rating.png', | |||
There was a problem hiding this comment.
That strange I tried to replace this line by Rating::ALL_RATING_ID => 'images/rating.png' and it seems to work fine
|
I made some remarks, once you test the change I propose, I'll merge it. Thanks ! |
Icons now working on rating details
|
Fixed and working: star icons now show on rating details page too. |
|
Thanks |
seblucas
added a commit
that referenced
this pull request
Jan 14, 2016
Images for feed categories - new set and missing ones
dunxd
pushed a commit
to dunxd/mikespub-cops
that referenced
this pull request
Sep 10, 2023
Images for feed categories - new set and missing ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images for categories missing from code · Issue #240 · seblucas/cops -
#240
New set of images created. 64*64 px
Tested on Android on light and dark backgrounds
Color used:
Color Hex #607b8b Light Sky Blue 4 -
http://www.color-hex.com/color/607b8b
Images are created from flaticon.com
You can make new ones online from this links:
http://www.flaticon.com/free-icon/user-silhouette_64096
http://www.flaticon.com/free-icon/books-piled-_14184
http://www.flaticon.com/free-icon/buildings_34271
http://www.flaticon.com/free-icon/signing-the-contract_66720
http://www.flaticon.com/free-icon/seo-tags_15564
http://www.flaticon.com/free-icon/abc-book_73353
http://www.flaticon.com/free-icon/small-wall-clock_3921
Creative Commons BY 3.0 Copyright notice for flaticon.com and
freepik.com included in Cops (required by icons tool)
Actual look on Android:
Light background / big icons (sized by the app Moon+reader)
Dark background / small icons (sized by the app FBReader)
Note: I was not able to make the rating detail page to also use the icons.
(as discussed in #240 (comment) )