Move /icons to /images and template updating (Apache issues) #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merci beaucoup Par contre tu as oublié https://github.com/seblucas/cops/blob/master/templates/bootstrap/file.html (faut mieux utiliser Sinon j'aurai préféré un message de commit en anglais (je tolère le français dans les tickets). Pas grave pour cette fois mais pour l'avenir. Thanks in advance ! |
cgxxx
changed the title
|
I have taken your advices into consideration and translated my PR ! ;) |
dunxd
pushed a commit
to dunxd/mikespub-cops
that referenced
this pull request
Sep 10, 2023
Move /icons to /images and template updating (Apache issues)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained on this page : http://www.electrictoolbox.com/apache-icons-directory/ , the /icons/ directory at root level of your project interferes with apache and can't be overrided with htaccess if you don't control the full Apache server yourself. I moved it into /images directory and updated templates files.