Disable PHP output buffering when reading file contents (fixes #389) #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I was facing the same issue as in #389 and there was always the option of playing with the PHP options but I wonder if the buffering shouldn't be disabled altogether in this kind of process.
So here the idea was to simply flush the output buffer and stop using it and then read the file contents.
Two notes:
But I also may be missing something here :)