Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout temperature alerts to entity #181

Merged
merged 16 commits into from
Jun 11, 2023
Merged

Breakout temperature alerts to entity #181

merged 16 commits into from
Jun 11, 2023

Conversation

disforw
Copy link
Contributor

@disforw disforw commented May 1, 2023

This PR will now create a binary sensor entity for each flood/temperature sensor that alerts on determined threshold. Set your threshold in the Bhyve app.

@disforw disforw marked this pull request as ready for review May 2, 2023 01:58
@disforw
Copy link
Contributor Author

disforw commented May 2, 2023

All tests complete

@disforw disforw mentioned this pull request May 21, 2023
Copy link
Owner

@sebr sebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left a few comments.

Have you discovered any API endpoints which can be called to change the thresholds? These would be useful to include as service endpoints. You can poke around at https://techsupport.orbitbhyve.com/ with the web inspector to try and uncover.

As well, if you could please update the README as relevant that would be appreciated.

custom_components/bhyve/binary_sensor.py Outdated Show resolved Hide resolved
custom_components/bhyve/binary_sensor.py Outdated Show resolved Hide resolved
custom_components/bhyve/binary_sensor.py Show resolved Hide resolved
disforw and others added 5 commits May 27, 2023 09:57
Change class name
Search for the word ALARM in alert string
Adding temp thresholds as attributes
@disforw disforw requested a review from sebr May 27, 2023 15:37
@disforw
Copy link
Contributor Author

disforw commented May 27, 2023

Made all requested changes,I looked in to changing the limits but can't find anything. If I find something in the future about it, I'll submit it as another pr.

Copy link
Contributor Author

@disforw disforw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go

@disforw
Copy link
Contributor Author

disforw commented May 28, 2023

{
    "last_connected_at": "2022-04-19T10:54:48.368Z",
    "location_name": "Laundry Room",
    "firmware_version": "16",
    "temp_alarm_thresholds": {
        "high_temp_f": 85,
        "low_temp_f": 55
    },
    "name": "Washing Machine",
    "type": "flood_sensor",
    "battery": {
        "percent": 100
    },
    "updated_at": "2023-05-28T17:42:58.221Z",
    "reference": "xxxxxxxxxx",
    "mac_address": "xxxxxxxx",
    "status": {
        "last_flood_alarm_at": "2023-05-20T01:49:21.951Z",
        "rssi": -84,
        "temp_f": 71.6,
        "provisioned": true,
        "phy": "le_1m_1000",
        "temp_alarm_status": "ok",
        "status_updated_at": "2023-05-28T17:42:58.220Z",
        "flood_alarm_status": "ok"
    },
    "id": "xxxxxxxxxxx",
    "auto_shutoff": false,
    "user_id": "xxxxxxx",
    "device_gateway_topic": "devices-2",
    "hardware_version": "fs1-0001",
    "is_connected": true,
    "created_at": "2021-08-26T21:47:11.293Z",
    "network_topology_id": "xxxxxxxxxxxxx"
},

@sebr sebr merged commit d05ec8f into sebr:main Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants