-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakout temperature alerts to entity #181
Conversation
All tests complete |
Testing ba`ttery attrs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have left a few comments.
Have you discovered any API endpoints which can be called to change the thresholds? These would be useful to include as service
endpoints. You can poke around at https://techsupport.orbitbhyve.com/ with the web inspector to try and uncover.
As well, if you could please update the README as relevant that would be appreciated.
Co-authored-by: Seb Ruiz <[email protected]>
Change class name
Search for the word ALARM in alert string
Adding temp thresholds as attributes
Made all requested changes,I looked in to changing the limits but can't find anything. If I find something in the future about it, I'll submit it as another pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go
|
This PR will now create a binary sensor entity for each flood/temperature sensor that alerts on determined threshold. Set your threshold in the Bhyve app.