Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a place to see what is the current roadmap? #87

Closed
cbene06 opened this issue Mar 15, 2016 · 26 comments
Closed

Is there a place to see what is the current roadmap? #87

cbene06 opened this issue Mar 15, 2016 · 26 comments

Comments

@cbene06
Copy link

cbene06 commented Mar 15, 2016

Hi,

I'd like to contribute and help in building a new feature. Is there a roadmap or/and any forum where we can discuss about it?

Thanks,
Christophe

@p-l-
Copy link
Member

p-l- commented Mar 15, 2016

Hi,

Glad to hear that, thanks for your interest in Scapy!

Maybe the best place to start is to open an issue mentioning the improvement / new feature you would like to contribute to track this?

@cbene06
Copy link
Author

cbene06 commented Mar 15, 2016

Hi Pierre,

I don't have improvement or new feature I would like to contribute yet; in fact it was the aim of my question ;-)

I would like to know if there is sleeping or ongoing development that requires resource, if that the case I would love to be part of it!

thanks,
Christophe.

----- Mail original -----
De: "Pierre Lalet" [email protected]
À: "secdev/scapy" [email protected]
Cc: "cbene06" [email protected]
Envoyé: Mardi 15 Mars 2016 16:46:11
Objet: Re: [scapy] Question: Is there a place to see what is the current roadmap? (#87)

Hi,

Glad to hear that, thanks for your interest in Scapy!

Maybe the best place to start is to open an issue mentioning the improvement / new feature you would like to contribute to track this?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#87 (comment)

@p-l-
Copy link
Member

p-l- commented Mar 15, 2016

Hi,

Nothing specific comes to my mind for now, but we'll open an issue if/when we have an idea (cc @guedou @phil777).

New protocols are always interesting and appreciated, and so are new high-level functions (like traceroute()).

@guedou
Copy link
Member

guedou commented Mar 15, 2016

Since Philippe asked us to maintain Scapy, our main tasks were mainly to fix issues. Therefore, there is no such thing as a roadmap. Due to the move to github, things seems to evolve differently as we get more and more contributors. A roadmap might indeed be a good idea =)

In the meantime, I have some ideas in mind. Most of them involve improving the documentation. This is an import task, as this the main entry point to gather more users.

  1. add unit tests to protocols in contrib/ Some of them don't have any test. This is problematic when we make changes to the core;
  2. check that the documentation is still up to date with the code;
  3. move examples from Scapy presentations to the documentation. According to some recent discussions I had, it seems that they are no synced.

@kinap
Copy link
Contributor

kinap commented Mar 16, 2016

Hi Christophe,

I'm not a part of the secdev team / maintainers, but here are some things I planned on submitting a pull request for in the next few months, maybe they will inspire you :).

  1. ChaCha20-Poly1305 (CCP) algorithm support to the IPSec layer. Requires contributing to pycrypto probably.
  2. unit tests for AEAD algorithms in IPSec layer (AES-GCM, AES-CCM, CCP).

Thanks,
Dan

@cbene06
Copy link
Author

cbene06 commented Mar 16, 2016

Thanks all for your answers. I'm ok also to work on bug fixes, specially when I'm starting to contribute. I don't see a lot of bugs opened right now however, right?

Regards,
Christophe

----- Mail original -----
De: "Daniel Collins" [email protected]
À: "secdev/scapy" [email protected]
Cc: "cbene06" [email protected]
Envoyé: Mercredi 16 Mars 2016 04:23:40
Objet: Re: [scapy] Question: Is there a place to see what is the current roadmap? (#87)

Hi Christophe,

I'm not a part of the secdev team / maintainers, but some things I planned on submitting a pull request for in the next few months:

1. ChaCha20-Poly1305 (CCP) algorithm support to the IPSec layer. Requires contributing to pycrypto probably. 
2. unit tests for AEAD algorithms in IPSec layer (AES-GCM, AES-CCM, CCP). 

Thanks,
Dan


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@guedou
Copy link
Member

guedou commented Mar 16, 2016

We did not yet fix everything that was reported on bitbucket https://bitbucket.org/secdev/scapy/wiki/Home

To start, it will be really cool if you could move pending bitbucket PR to github after contacting their authors.

@cbene06
Copy link
Author

cbene06 commented Mar 17, 2016

ok I will start with that. I suppose I should contact only the owner of unassigned PR, right?

----- Mail original -----
De: "Guillaume Valadon" [email protected]
À: "secdev/scapy" [email protected]
Cc: "cbene06" [email protected]
Envoyé: Mercredi 16 Mars 2016 17:25:10
Objet: Re: [scapy] Question: Is there a place to see what is the current roadmap? (#87)

We did not yet fix everything that was reported on bitbucket https://bitbucket.org/secdev/scapy/wiki/Home

To start, it will be really cool if you could move pending bitbucket PR to github after contacting their authors.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@cbene06
Copy link
Author

cbene06 commented Mar 17, 2016

I saw there is tools to make it, for example: https://github.com/jeffwidman/bitbucket-issue-migration

I will make a try if you all agree.

Thanks

----- Mail original -----
De: "Guillaume Valadon" [email protected]
À: "secdev/scapy" [email protected]
Cc: "cbene06" [email protected]
Envoyé: Mercredi 16 Mars 2016 17:25:10
Objet: Re: [scapy] Question: Is there a place to see what is the current roadmap? (#87)

We did not yet fix everything that was reported on bitbucket https://bitbucket.org/secdev/scapy/wiki/Home

To start, it will be really cool if you could move pending bitbucket PR to github after contacting their authors.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@guedou
Copy link
Member

guedou commented Mar 17, 2016

@cbene06 Sorry I realize that I did not clearly write what I expected.

Concerning BB issues, I think that it is better to leave them on BB. A lot of them were created on trac before migrating to BB. Therefore, I believe that most of them are irrelevant today.
On the other hand, you can have a look at "new" (until 2012) BB issues, reproduce them, then close them on BB, or fix them via a github PR.

Concerning BB pull-requests, I think that the best is to contact their authors on BB and inform them that Scapy moved to github. You can inform them, that they can submit a new PR on github or you can do it for them. Please keep their name & email adress in the commit message if you do so.

Thanks a lot for your help.

@p-l- p-l- changed the title Question: Is there a place to see what is the current roadmap? Is there a place to see what is the current roadmap? Mar 20, 2016
@xee5ch
Copy link

xee5ch commented Mar 20, 2016

Well I am coming here after seeing #92 was closed. Is there any progress on migrating Bitbucket issues? Is there anything else a noivce can do with documentation to help out?

@p-l-
Copy link
Member

p-l- commented Mar 20, 2016

@AJStein that's the good place!

As @guedou said, we do not want to automatically migrate issues from Bitbucket, since some (most?) of them have been abandoned by their author or are no longer valid.

If you find a issue there that is valid for you, you can open an issue here, link it to the original issue on Bitbucket (that you can close, referencing the issue on Github).

As I mentioned in a previous comment, "new protocols are always interesting and appreciated, and so are new high-level functions (like traceroute())."

@xee5ch
Copy link

xee5ch commented Mar 20, 2016

So, in response to your points:

  • My Python skills are weak after a long hiatus. I am trying to get back to it. I will think about something traceroute. Sounds like an interesting start.
  • In the meantime, I will review Bitbucket issues and see what I can find.

@p-l-
Copy link
Member

p-l- commented Mar 20, 2016

@AJStein be careful, traceroute() already exists.

Another option is to try to do something with Scapy, and either write functions to do it, or write a documentation to show how you did it, maybe as an iPython Notebook.

@xee5ch
Copy link

xee5ch commented Mar 20, 2016

Sorry, I should not speak so loosely. I obviously have not reviewed the code so deeply. I am looking at Bitbucket for inspiration for easier stuff. Then I will work my way up if possible.

@p-l-
Copy link
Member

p-l- commented Mar 20, 2016

No problem, I just wanted to make sure you wouldn't start writing something that already exists. Good luck and don't hesitate to ask for help / advise.

@irl
Copy link
Contributor

irl commented Sep 24, 2016

From the perspective of Debian, I've noticed that a lot of the files in Scapy do not have clear licensing or copyright notices. Please keep in mind for future development that simply copying and pasting code chunks from bug trackers may be easy, but it creates work for others, that may lead to that code simply not being shipped in the Debian package.

@guedou
Copy link
Member

guedou commented Sep 27, 2016

@irl could you be more specific and provide examples of what should be done or not done to make Debian maintainers life easier ? Thanks.

@irl
Copy link
Contributor

irl commented Sep 27, 2016

@guedou Clear copyright notices, that state the year, copyright owner and the license grant. This can be per file if everyone wants to contribute and have different licenses but this leads to futher problems. For example, you have GPL-2 and GPL-3 code, which cannot work together. The GPL-2 code must be GPL-2 forever because the "or at your option, any later version" was not added in the license grant, and the GPL-3+ code even with the "or at your option" clause cannot be compatible with GPL-2. Licensing is a nightmare.

@geofurb
Copy link

geofurb commented Oct 31, 2016

Is porting Scapy to Python 3.x something that might be reconsidered since discontinuation of Python 2.5 support?

@irl
Copy link
Contributor

irl commented Oct 31, 2016

@geofurb https://github.com/phaethon/scapy is a port of Scapy to Python 3, and I've packaged this in Debian as python3-scapy though I would love to see these changes merged into a Py2/Py3/PyPy all-in-one source to be able to build all three Debian packages from the same source package as is done with basically every other Python package (at least for Py2/Py3).

@geofurb
Copy link

geofurb commented Oct 31, 2016

@irl I'm equally happy to use Scapy3k, I'm just hesitant because I'm not sure what the differences are between the latest version of each. (I know strings vs bytes is a big deal somewhere in all of this, but I'm not sure about specifics and what else might be changed.)

@irl
Copy link
Contributor

irl commented Oct 31, 2016

It's mostly strings vs bytes. I'm not entirely sure if Scapy3k is being kept in sync with Scapy with a view to merging or if it's just a plain fork though.

@guedou
Copy link
Member

guedou commented Nov 3, 2016

Porting the current codebase to Python 3 is currently not on our roadmap. We believe that it more important to invest in a new Scapy rewrite. A prototype is available at: https://bitbucket.org/secdev/scapy3-prototype2. If you fill like it, we could also discuss guidelines that will ease porting to Python 3.

@gpotter2
Copy link
Member

gpotter2 commented Dec 18, 2016

I've published a RoadMap from what i've found in scapy's code; and there is much to do 😄
We've updated it with all the issues.
See : #399

@p-l-
Copy link
Member

p-l- commented Dec 21, 2016

"Closed" by #399.

@p-l- p-l- closed this as completed Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants