Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: Add EIR service solicitation types #4602

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

antoniovazquezblanco
Copy link
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

Add new Bluetooth EIR types :)

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (c2ce8dc) to head (b6c8f15).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4602      +/-   ##
==========================================
+ Coverage   81.61%   81.62%   +0.01%     
==========================================
  Files         358      358              
  Lines       85678    85692      +14     
==========================================
+ Hits        69927    69950      +23     
+ Misses      15751    15742       -9     
Files with missing lines Coverage Δ
scapy/layers/bluetooth.py 90.15% <100.00%> (+0.13%) ⬆️

... and 9 files with indirect coverage changes

@XenoKovah
Copy link

I just wanted to voice support for this PR since it will add export for data types which I'd like to export from BLE pcaps.

@p-l- p-l- merged commit a8583a5 into secdev:master Dec 11, 2024
24 checks passed
@antoniovazquezblanco
Copy link
Contributor Author

Thanks!

@gpotter2 gpotter2 mentioned this pull request Dec 22, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants