Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix#4556- Fix enum mismatch by changing keys to bytes in dict #4609

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

satveerbrar
Copy link
Contributor

fixes #4556

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (a8583a5) to head (00f9b5e).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4609      +/-   ##
==========================================
- Coverage   81.38%   78.70%   -2.69%     
==========================================
  Files         359      334      -25     
  Lines       86029    80830    -5199     
==========================================
- Hits        70017    63618    -6399     
- Misses      16012    17212    +1200     
Files with missing lines Coverage Δ
scapy/layers/ntp.py 85.28% <ø> (-0.04%) ⬇️

... and 286 files with indirect coverage changes

@gpotter2
Copy link
Member

Thanks for the PR !

@gpotter2 gpotter2 merged commit ce81649 into secdev:master Dec 28, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Str*EnumField parses into bytes, not str
2 participants