Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blake2b hashing support #4

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Add blake2b hashing support #4

merged 1 commit into from
Sep 28, 2022

Conversation

VectorMutt
Copy link
Contributor

@VectorMutt VectorMutt commented Sep 28, 2022 •
edited
Loading

This add supports for blake2b hashing to packages as well as a new field to the results dict

@bennettgoble
Copy link
Member

bennettgoble commented Sep 28, 2022 •
edited
Loading

Thanks for the PR, @RyeMutt. These changes look good: one style nit to patch and I'd be happy to have it merged.

Edit: will need to patch up the tests as well.

@VectorMutt VectorMutt force-pushed the blake2b branch 3 times, most recently from ce2734a to 8c222ed Compare September 28, 2022 00:30
bennettgoble
bennettgoble approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@bennettgoble bennettgoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@bennettgoble bennettgoble added the enhancement New feature or request label Sep 28, 2022
@bennettgoble bennettgoble merged commit 4e63112 into secondlife:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennettgoble bennettgoble bennettgoble approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VectorMutt @bennettgoble