Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include session id with last exec event #3431

Open
kylelinden opened this issue Jan 17, 2025 · 7 comments
Open

Include session id with last exec event #3431

kylelinden opened this issue Jan 17, 2025 · 7 comments
Assignees
Labels
enhancement New feature or request team:viewer

Comments

@kylelinden
Copy link

kylelinden commented Jan 17, 2025

Test plan

Test needed.

Description

Include session id with last exec event

@kylelinden kylelinden added enhancement New feature or request team:viewer labels Jan 17, 2025
@akleshchev
Copy link
Contributor

akleshchev commented Jan 20, 2025

Startup crashes have no session ids, how should that case be treated? Just a locally generated UUID? Or should be there some different identifier for such crashes? Like packing session id and viewer's 'instance' id.

@akleshchev
Copy link
Contributor

At review, should I also include session id in bugsplat's attributes?

@nat-goodspeed
Copy link
Contributor

Sounds like a good idea, to correlate BugSplat crashes with our own crash information.

@akleshchev
Copy link
Contributor

On practice turned out to be a bit complicated. Windows part is trivial, but Mac needs to pull session id from dump files (and probably is going to be as unreliable as Mac's logs are), will make a separate ticket.

@akleshchev
Copy link
Contributor

akleshchev commented Jan 31, 2025

Server side confirmed that they are getting last_exec_session_id, just needs filters now.
https://lindenlab.slack.com/archives/C02R43FJP/p1738348642853739

@AtlasLinden
Copy link
Contributor

Given the above comment, this will be considered to have passed viewer QA if no obvious issues are found in the next round of testing.

@Dan-Linden
Copy link
Contributor

Nothing further to test on the viewer side. Passing QA on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request team:viewer
Projects
None yet
Development

No branches or pull requests

5 participants