-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include session id with last exec event #3431
Comments
Startup crashes have no session ids, how should that case be treated? Just a locally generated UUID? Or should be there some different identifier for such crashes? Like packing session id and viewer's 'instance' id. |
At review, should I also include session id in bugsplat's attributes? |
Sounds like a good idea, to correlate BugSplat crashes with our own crash information. |
On practice turned out to be a bit complicated. Windows part is trivial, but Mac needs to pull session id from dump files (and probably is going to be as unreliable as Mac's logs are), will make a separate ticket. |
Server side confirmed that they are getting last_exec_session_id, just needs filters now. |
Given the above comment, this will be considered to have passed viewer QA if no obvious issues are found in the next round of testing. |
Nothing further to test on the viewer side. Passing QA on this. |
Test plan
Test needed.
Description
Include session id with last exec event
The text was updated successfully, but these errors were encountered: